Wrap HirIds of locals into LocalVarIds for THIR nodes
#97913
Merged
+53
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Jun 9, 2022
|
@bors r+ |
|
📌 Commit 6cad569 has been approved by |
bors
added
S-waiting-on-bors
|
@wesleywiser this is part of a larger refactoring for let-else that I've been working with @dingxiangfei2009 to achieve |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 10, 2022
…r-id, r=nikomatsakis Wrap `HirId`s of locals into `LocalVarId`s for THIR nodes This is the first effort to decouple `HirId`s from THIR. `HirId` is not very relevant in building THIR and MIR. Based on the changeset, I think there are a few other pending refactoring that we could perform after this, in case we want to eliminate use of `HirId` in THIR. - `TypeckResults::closure_min_captures` could be remapped from the variable `HirId`s to `LocalVarId` while the THIR is getting built. - Use of `ScopeTree::var_scope` could be eliminated as well, since we will consider deprecating `ScopeTree` in the future.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97761 (validating the vtable can lead to Stacked Borrows errors) - rust-lang#97789 (Fix rust-lang#71363's test by adding `-Z translate-remapped-path-to-local-path=no`) - rust-lang#97913 (Wrap `HirId`s of locals into `LocalVarId`s for THIR nodes) - rust-lang#97979 (Fix typos in Provider API docs) - rust-lang#97987 (remove an unnecessary `String`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first effort to decouple
HirIds from THIR.HirIdis not very relevant in building THIR and MIR.Based on the changeset, I think there are a few other pending refactoring that we could perform after this, in case we want to eliminate use of
HirIdin THIR.TypeckResults::closure_min_capturescould be remapped from the variableHirIds toLocalVarIdwhile the THIR is getting built.ScopeTree::var_scopecould be eliminated as well, since we will consider deprecatingScopeTreein the future.